Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Query for remove brick async task status
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 27: Guid volumeId = getParameters().getVolumeId();
Line 28: if (volumeId != null) {
Line 29: volume = getGlusterVolumeDao().getById(volumeId);
Line 30: if (volume == null) {
Line 31: throw new RuntimeException(String.format("Invalid
volume id %s", volumeId));
Can't we throw here something more meaningful?
Where are you using this query? how does it feel in this case?
Line 32: }
Line 33: }
Line 34:
Line 35: if(clusterId == null) {
--
To view, visit http://gerrit.ovirt.org/19114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4ec67f058bc9198bb6e1dfc96d0677294d93e9e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
