Shubhendu Tripathi has posted comments on this change.
Change subject: engine:BLL Command to Start Remove Gluster volume brick
......................................................................
Patch Set 16:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 82: }
Line 83: }
Line 84:
Line 85: private void removeBricksFromVolumeInDb(List<GlusterBrickEntity>
brickList) {
Line 86: GlusterVolumeEntity volume = getGlusterVolume();
Will try using the spring JDBC here
Line 87: for (GlusterBrickEntity brick : brickList) {
Line 88: getGlusterBrickDao().removeBrick(brick.getId());
Line 89: }
Line 90: // Update volume type and replica/stripe count
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommand.java
Line 80: }
Line 81:
Line 82: protected void updateBricksWithTaskID(GlusterAsyncTask asyncTask) {
Line 83: for (GlusterBrickEntity brickEntity :
getParameters().getBricks()) {
Line 84: getGlusterBrickDao().updateBrickTask(brickEntity.getId(),
asyncTask.getTaskId());
Will try using the spring jdbc
Line 85: }
Line 86: getGlusterVolumeDao().updateVolumeTask(getGlusterVolumeId(),
asyncTask.getTaskId());
Line 87: }
Line 88:
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java
Line 18: public class GlusterBrickDaoTest extends BaseDAOTestCase {
Line 19: private static final Guid SERVER_ID = new
Guid("afce7a39-8e8c-4819-ba9c-796d316592e6");
Line 20: private static final Guid EXISTING_VOL_ID = new
Guid("0c3f45f6-3fe9-4b35-a30c-be0d1a835ea8");
Line 21: private static final Guid EXISTING_BRICK_ID = new
Guid("6ccdc294-d77b-4929-809d-8afe7634b47d");
Line 22: private static final Guid EXISTING_BRICK_ID_1 = new
Guid("61c94fc7-26b0-43e3-9d26-fc9d8cd6a754");
Yes, will do that
Line 23:
Line 24: private static final Guid BRICK_SERVER_ID = new
Guid("23f6d691-5dfb-472b-86dc-9e1d2d3c18f3");
Line 25: private static final String BRICK_DIRECTORY =
"/export/test-vol-distribute-1/dir1";
Line 26:
....................................................
File
packaging/dbscripts/upgrade/03_03_0900_add_start_remove_gluster_volume_birck_to_event_map.sql
Line 1: insert into event_map(event_up_name, event_down_name)
values('START_REMOVING_GLUSTER_VOLUME_BRICKS', 'UNASSIGNED');
Will correct
Line 2: insert into event_map(event_up_name, event_down_name)
values('START_REMOVING_GLUSTER_VOLUME_BRICKS_FAILED',
'START_REMOVING_GLUSTER_VOLUME_BRICKS');
--
To view, visit http://gerrit.ovirt.org/18923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ee4620b75b4b714087dbf1dec3720661a5ce6b
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
