Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for absolute app path
......................................................................
Patch Set 2:
(2 comments)
> Juan, with your permission I want to rebase this over master, fix the comment
> and submit, as functionality is useful regardless of this set.
Go ahead. However this is mostly worthless if it isn't combined with the rest
of the changes to support independent deployments.
....................................................
File packaging/conf/engine.conf.defaults.in
Line 107: # started by the engine. This is a list of space separated files or
Line 108: # directories that should be either absolute or relative to the value
of
Line 109: # the ENGINE_USR parameter:
Line 110: #
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
I don't understand why we want to use this weird shell syntax in a
configuration file. If you really feel the need to support spaces in path names
change the config class to use a different separator.
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
Line 111: ENGINE_APPS="@ENGINE_BEANS@"
Line 112: ENGINE_APPS="${ENGINE_APPS} @ENGINE_ROOT@"
Line 113: ENGINE_APPS="${ENGINE_APPS} @ENGINE_RESTAPI@"
Line 114: ENGINE_APPS="${ENGINE_APPS} @ENGINE_USERPORTAL@"
Line 115: ENGINE_APPS="${ENGINE_APPS} @ENGINE_WEBADMIN@"
I prefer to avoid that extra "wars" directory.
Line 116:
Line 117: #
Line 118: # Flags to enable or disable the web server (the proxy) and the
Line 119: # connectors of the application server:
--
To view, visit http://gerrit.ovirt.org/13796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abd8c33bf4e879372dc3cf43b55f24ccdcfd6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
