Kanagaraj M has posted comments on this change.
Change subject: webadmin: remove bricks with migration support
......................................................................
Patch Set 3:
(4 comments)
New patch set to follow
....................................................
Commit Message
Line 7: webadmin: remove bricks with migration support
Line 8:
Line 9: Added a new Checkbox 'Migrate Data' to the Remove Bricks
Line 10: Confirmation popup. And a warning message in the bottom
Line 11: explaining the necessity to migrate the data before remove.
Its there
Line 12:
Line 13: The bricks in the confirmation popup is wrapped inside
Line 14: a ScrollPanel to avoid the overflowing if more number of
Line 15: bricks are selected.
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 1713: @DefaultStringValue("Cannot remove more than one brick from a
Replicate volume at a time")
Line 1714: String cannotRemoveBricksReplicateVolume();
Line 1715:
Line 1716: @DefaultStringValue("Incorrect bricks selected for the removal
in Distributed Replicate volume. <br/> Either all the selected bricks should be
from the same sub volume or one brick each for every sub volume!")
Line 1717: String cannotRemoveBricksDistributedReplicateVolume();
Done
Line 1718:
Line 1719: @DefaultStringValue("Incorrect bricks selected for the removal
in Distributed Stripe volume. <br/> Selected bricks should be from the same sub
volume!")
Line 1720: String cannotRemoveBricksDistributedStripeVolume();
Line 1721:
Line 1716: @DefaultStringValue("Incorrect bricks selected for the removal
in Distributed Replicate volume. <br/> Either all the selected bricks should be
from the same sub volume or one brick each for every sub volume!")
Line 1717: String cannotRemoveBricksDistributedReplicateVolume();
Line 1718:
Line 1719: @DefaultStringValue("Incorrect bricks selected for the removal
in Distributed Stripe volume. <br/> Selected bricks should be from the same sub
volume!")
Line 1720: String cannotRemoveBricksDistributedStripeVolume();
Done
Line 1721:
Line 1722: @DefaultStringValue("Incorrect bricks selected for the removal
in Striped Replicate volume. <br/> Selected bricks should be a multiple of
stripe and replica count")
Line 1723: String cannotRemoveBricksStripedReplicateVolume();
Line 1724:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2681: @DefaultStringValue("Ensure safe data migration before removing
the bricks")
Line 2682: String removeBricksMigrateDataInfo();
Line 2683:
Line 2684: @DefaultStringValue("Please note that data will be lost if
choose not to migrate")
Line 2685: String removeBricksWarning();
Done
Line 2686:
Line 2687: // Volume Brick Details
Line 2688: @DefaultStringValue("General")
Line 2689: String generalBrickAdvancedPopupLabel();
--
To view, visit http://gerrit.ovirt.org/19201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aae4548661ff1cb9f93a14ab66b6c41bc201bbd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
