Lior Vernia has posted comments on this change.
Change subject: frontend: Select an empty profile does not work
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 383: // Save changes.
Line 384: nic.setName((String) getName().getEntity());
Line 385: VnicProfileView profile = (VnicProfileView)
getProfile().getSelectedItem();
Line 386: nic.setVnicProfileId(profile != null ? profile.getId() :
null);
Line 387: nic.setNetworkName(profile != null ? profile.getNetworkName()
: null);
I don't see what further refactoring would be necessary. The patch already
touches all calls to VmNetworkInterface.setProfileId() in the frontend, so
might as well make the calls more maintainable.
I'm not sure if the backend could even use a method like
VmNetworkInterface.assignProfile(VnicProfile), but if it could, that could be
done in a different patch. You're probably right though that setVnicProfileId()
shouldn't be flagged as deprecated.
Line 388: nic.setLinked((Boolean) getLinked().getEntity());
Line 389: if (getNicType().getSelectedItem() == null)
Line 390: {
Line 391: nic.setType(null);
--
To view, visit http://gerrit.ovirt.org/18791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
