Doron Fediuck has posted comments on this change.
Change subject: core: Audit log failed external scheduler discovery
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
See inline for several functional issues.
Also, we need to think of a case when the service stops (crash) after discovery
ended. How will you handle it?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
Line 30: updateDB(discoveryResult);
Line 31: log.info("PolicyUnits updated");
Line 32: } else {
Line 33: AuditLogableBase loggable = new AuditLogableBase();
Line 34: AuditLogDirector.log(loggable,
AuditLogType.FAILED_TO_CONNECT_TO_SCHEDULER_PROXY);
Hmmm.... Do we always fail to connect? Even when there are no user plugins and
connection works?
Line 35: }
Line 36: }
Line 37:
Line 38: private void updateDB(ExternalSchedulerDiscoveryResult
discoveryResult) {
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 693: USER_UPDATE_CLUSTER_POLICY=Clsuter Policy ${ClusterPolicy} was
updated. (User: ${UserName})
Line 694: USER_FAILED_TO_UPDATE_CLUSTER_POLICY=Failed to update Clsuter Policy:
${ClusterPolicy}. (User: ${UserName})
Line 695: USER_REMOVE_CLUSTER_POLICY=Clsuter Policy ${ClusterPolicy} was
removed. (User: ${UserName})
Line 696: USER_FAILED_TO_REMOVE_CLUSTER_POLICY=Failed to remove Clsuter Policy:
${ClusterPolicy}. (User: ${UserName})
Line 697: FAILED_TO_CONNECT_TO_SCHEDULER_PROXY=Failed to connect to external
scheduler proxy. External filters, scoring functions and load balancing will
not be performed.
Please fix the TWS.
Line 698: EXTERNAL_EVENT_NORMAL=An external event with NORMAL severity has been
added.
Line 699: EXTERNAL_EVENT_WARNING=An external event with WARNING severity has
been added.
Line 700: EXTERNAL_EVENT_ERROR=An external event with ERROR severity has been
added.
Line 701: EXTERNAL_ALERT=An external event with ALERT severity has been added.
--
To view, visit http://gerrit.ovirt.org/19283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I198b4fd6300d903fcce55afc400a3075af1ea11c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
