Sandro Bonazzola has posted comments on this change.
Change subject: tools: Add script to dump heap
......................................................................
Patch Set 8:
(1 comment)
....................................................
File packaging/bin/engine-heap-dump.sh
Line 97:
Line 98: become_ovirt "$0" "$@"
Line 99:
Line 100: if [ -z "${PID}" ]; then
Line 101: PID="$(pidof ovirt-engine)" || die "The engine is not running"
In http://gerrit.ovirt.org/#/c/19365/ Roy suggested to use
/var/run/ovirt-engine.pid and
ENGINE_MARK_UP which in his env is translated to
$PREFIX/var/lib/ovirt-engine/engine.up
Just in order to adopt the same solution for having that PID, can you comment
on why using pidof is better or not compared to getting it from the above files?
Line 102: fi
Line 103:
Line 104: dump "${OUTDIR}/${PREFIX}" "${PID}"
Line 105:
--
To view, visit http://gerrit.ovirt.org/17470
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic337441123a7129d71c0a90aa4b12c8ec49c03c7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
