Hello Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19519
to review the following change.
Change subject: backend: unlock imported glance image on create errors
......................................................................
backend: unlock imported glance image on create errors
When the serial execution of tasks for ImportRepoImageCommand fails in
the first handler we should make sure to remove the disk as well.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006400
Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916
Signed-off-by: Federico Simoncelli <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/19519/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
index 74fbcf2..0cca59c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
@@ -14,6 +14,7 @@
import org.ovirt.engine.core.common.asynctasks.EntityInfo;
import org.ovirt.engine.core.common.businessentities.DiskImage;
import org.ovirt.engine.core.common.businessentities.DiskInterface;
+import org.ovirt.engine.core.common.businessentities.ImageStatus;
import org.ovirt.engine.core.common.businessentities.StorageDomain;
import org.ovirt.engine.core.common.businessentities.VolumeFormat;
import org.ovirt.engine.core.common.businessentities.VolumeType;
@@ -103,6 +104,11 @@
@Override
public void endWithFailure() {
+
enclosingCommand.getParameters().getDiskImage().setImageStatus(ImageStatus.ILLEGAL);
+ ImagesHandler.updateImageStatus(
+ enclosingCommand.getParameters().getDiskImage().getImageId(),
+
enclosingCommand.getParameters().getDiskImage().getImageStatus());
+ compensate();
enclosingCommand.getReturnValue().setSucceeded(true);
}
--
To view, visit http://gerrit.ovirt.org/19519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
