Moti Asayag has uploaded a new change for review. Change subject: webadmin: Refactor RoleTreeView ......................................................................
webadmin: Refactor RoleTreeView RoleTreeView had too long and complicated method with too many indentation levels. The patch reduces the complexity and allows new entities to be added more easily to the Action Groups tree. Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Related-To: https://bugzilla.redhat.com/1002483 Signed-off-by: Moti Asayag <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 207 insertions(+), 341 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/19525/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java index b98a3fe..ea758d0 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java @@ -8,6 +8,7 @@ import org.ovirt.engine.ui.uicommonweb.models.ApplicationModeHelper; import org.ovirt.engine.ui.uicommonweb.models.common.SelectionTreeNodeModel; import org.ovirt.engine.ui.uicompat.ConstantsManager; +import org.ovirt.engine.ui.uicompat.UIConstants; @SuppressWarnings("unused") public class RoleTreeView @@ -65,348 +66,19 @@ private static RoleNode initTreeView() { RoleNode tree = - new RoleNode(ConstantsManager.getInstance().getConstants().rootRoleTree(), + new RoleNode(getConstants().rootRoleTree(), new RoleNode[] { - new RoleNode(ConstantsManager.getInstance().getConstants().systemRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureSystemRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.MANIPULATE_USERS, - ConstantsManager.getInstance() - .getConstants() - .allowToAddRemoveUsersFromTheSystemRoleTreeTooltip()), - new RoleNode(ActionGroup.MANIPULATE_PERMISSIONS, - ConstantsManager.getInstance() - .getConstants() - .allowToAddRemovePermissionsForUsersOnObjectsInTheSystemRoleTreeTooltip()), - new RoleNode(ActionGroup.MANIPULATE_ROLES, - ConstantsManager.getInstance() - .getConstants() - .allowToDefineConfigureRolesInTheSystemRoleTreeTooltip()), - new RoleNode(ActionGroup.LOGIN, - ConstantsManager.getInstance() - .getConstants() - .allowToLoginToTheSystemRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_ENGINE, - ConstantsManager.getInstance() - .getConstants() - .allowToGetOrSetSystemConfigurationRoleTreeTooltip()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().dataCenterRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureDataCenterRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_STORAGE_POOL, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateDataCenterRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_STORAGE_POOL, - ConstantsManager.getInstance() - .getConstants() - .allowToRemoveDataCenterRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, - ConstantsManager.getInstance() - .getConstants() - .allowToModifyDataCenterPropertiesRoleTreeTooltip()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().networkRoleTree(), - new RoleNode[] { - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureNetworkRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_STORAGE_POOL_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateLogicalNetworkPerDataCenterRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToEditLogicalNetworkRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_STORAGE_POOL_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToDeleteLogicalNetworkRoleTreeTooltip()), - new RoleNode(ActionGroup.ASSIGN_CLUSTER_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToAddRemoveLogicalNetworksForTheClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_VM_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToConfigureVMsNetworkRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_TEMPLATE_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToConfigureTemlateNetworkRoleTreeTooltip()) }) }), - new RoleNode(ConstantsManager.getInstance().getConstants().storageDomainRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureStorageDomainRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_STORAGE_DOMAIN, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateStorageDomainRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_STORAGE_DOMAIN, - ConstantsManager.getInstance() - .getConstants() - .allowToDeleteStorageDomainRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_STORAGE_DOMAIN_CONFIGURATION, - ConstantsManager.getInstance() - .getConstants() - .allowToModifyStorageDomainPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.MANIPULATE_STORAGE_DOMAIN, - ConstantsManager.getInstance() - .getConstants() - .allowToChangeStorageDomainStatusRoleTreeTooltip()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().clusterRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureClusterRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_CLUSTER, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateNewClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_CLUSTER, - ConstantsManager.getInstance() - .getConstants() - .allowToRemoveClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_CLUSTER_CONFIGURATION, - ConstantsManager.getInstance() - .getConstants() - .allowToEditClusterPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_CLUSTER_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToEditLogicalNetworksForTheClusterRoleTreeTooltip()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().glusterRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureVolumesRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_GLUSTER_VOLUME, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateGlusterVolumesRoleTree()), - new RoleNode(ActionGroup.MANIPULATE_GLUSTER_VOLUME, - ConstantsManager.getInstance() - .getConstants() - .allowToManipulateGlusterVolumesRoleTree()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().hostRoleTree(), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .configureHostRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_HOST, - ConstantsManager.getInstance() - .getConstants() - .allowToAddNewHostToTheClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_HOST, - ConstantsManager.getInstance() - .getConstants() - .allowToRemoveExistingHostFromTheClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_HOST_CONFIGURATION, - ConstantsManager.getInstance() - .getConstants() - .allowToEditHostPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.MANIPUTLATE_HOST, - ConstantsManager.getInstance() - .getConstants() - .allowToChangeHostStatusRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_HOST_NETWORK, - ConstantsManager.getInstance() - .getConstants() - .allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip()) })), - new RoleNode(ConstantsManager.getInstance().getConstants().templateRoleTree(), - new RoleNode[] { - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .basicOperationsRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.EDIT_TEMPLATE_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowToChangeTemplatePropertiesRoleTreeTooltip()) }), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .provisioningOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_TEMPLATE, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateNewTemplateRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_TEMPLATE, - ConstantsManager.getInstance() - .getConstants() - .allowToRemoveExistingTemplateRoleTreeTooltip()), - new RoleNode(ActionGroup.IMPORT_EXPORT_VM, - ConstantsManager.getInstance() - .getConstants() - .allowImportExportOperationsRoleTreeTooltip()), - new RoleNode(ActionGroup.COPY_TEMPLATE, - ConstantsManager.getInstance() - .getConstants() - .allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip()) }), - - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .administrationOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainigTheseOperationsShuoldAssociatDcOrEqualRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.EDIT_ADMIN_TEMPLATE_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowChangingTemplateAdminPropertiesRoleTreeTooltip()) }) }), - - new RoleNode(ConstantsManager.getInstance().getConstants().vmRoleTree(), - new RoleNode[] { - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .basicOperationsRoleTree(), - new RoleNode[] { - new RoleNode(ActionGroup.VM_BASIC_OPERATIONS, - ConstantsManager.getInstance() - .getConstants() - .allowBasicVmOperationsRoleTreeTooltip()), - new RoleNode(ActionGroup.CHANGE_VM_CD, - ConstantsManager.getInstance() - .getConstants() - .allowToAttachCdToTheVmRoleTreeTooltip()), - new RoleNode(ActionGroup.CONNECT_TO_VM, - ConstantsManager.getInstance() - .getConstants() - .allowViewingTheVmConsoleScreenRoleTreeTooltip()) }), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .provisioningOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.EDIT_VM_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowChangeVmPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.CREATE_VM, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateNewVmsRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_VM, - ConstantsManager.getInstance() - .getConstants() - .allowToRemoveVmsFromTheSystemRoleTreeTooltip()), - new RoleNode(ActionGroup.IMPORT_EXPORT_VM, - ConstantsManager.getInstance() - .getConstants() - .allowImportExportOperationsRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_VM_STORAGE, - ConstantsManager.getInstance() - .getConstants() - .allowToAddRemoveDiskToTheVmRoleTreeTooltip()), - new RoleNode(ActionGroup.MANIPULATE_VM_SNAPSHOTS, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateDeleteSnapshotsOfTheVmRoleTreeTooltip()) }), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .administrationOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainigTheseOperationsShuoldAssociatDcOrEqualRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.MOVE_VM, - ConstantsManager.getInstance() - .getConstants() - .allowToMoveVmImageToAnotherStorageDomainRoleTreeTooltip()), - new RoleNode(ActionGroup.MIGRATE_VM, - ConstantsManager.getInstance() - .getConstants() - .allowMigratingVmBetweenHostsInClusterRoleTreeTooltip()), - new RoleNode(ActionGroup.CHANGE_VM_CUSTOM_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowToChangeVmCustomPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_ADMIN_VM_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowChangingVmAdminPropertiesRoleTreeTooltip()), - new RoleNode(ActionGroup.RECONNECT_TO_VM, - ConstantsManager.getInstance() - .getConstants() - .allowReconnectToVmRoleTreeTooltip()) }) }), - new RoleNode(ConstantsManager.getInstance().getConstants().vmPoolRoleTree(), - new RoleNode[] { - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .basicOperationsRoleTree(), - new RoleNode[] { new RoleNode(ActionGroup.VM_POOL_BASIC_OPERATIONS, - ConstantsManager.getInstance() - .getConstants() - .allowToRunPauseStopVmFromVmPoolRoleTreeTooltip()) }), - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .provisioningOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_VM_POOL, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateVmPoolRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_VM_POOL, - ConstantsManager.getInstance() - .getConstants() - .allowToDeleteVmPoolRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_VM_POOL_CONFIGURATION, - ConstantsManager.getInstance() - .getConstants() - .allowToChangePropertiesOfTheVmPoolRoleTreeTooltip()) }) }), - - new RoleNode(ConstantsManager.getInstance().getConstants().diskRoleTree(), - new RoleNode[] { - new RoleNode(ConstantsManager.getInstance() - .getConstants() - .provisioningOperationsRoleTree(), - ConstantsManager.getInstance() - .getConstants() - .notePermissionsContainingOperationsRoleTreeTooltip(), - new RoleNode[] { - new RoleNode(ActionGroup.CREATE_DISK, - ConstantsManager.getInstance() - .getConstants() - .allowToCreateDiskRoleTreeTooltip()), - new RoleNode(ActionGroup.DELETE_DISK, - ConstantsManager.getInstance() - .getConstants() - .allowToDeleteDiskRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_DISK_STORAGE, - ConstantsManager.getInstance() - .getConstants() - .allowToMoveDiskToAnotherStorageDomainRoleTreeTooltip()), - new RoleNode(ActionGroup.ATTACH_DISK, - ConstantsManager.getInstance() - .getConstants() - .allowToAttachDiskToVmRoleTreeTooltip()), - new RoleNode(ActionGroup.EDIT_DISK_PROPERTIES, - ConstantsManager.getInstance() - .getConstants() - .allowToChangePropertiesOfTheDiskRoleTreeTooltip()), - new RoleNode(ActionGroup.CONFIGURE_SCSI_GENERIC_IO, - ConstantsManager.getInstance() - .getConstants() - .allowToChangeSGIORoleTreeTooltip()), - new RoleNode(ActionGroup.ACCESS_IMAGE_STORAGE, - ConstantsManager.getInstance() - .getConstants() - .allowAccessImageDomainRoleTreeTooltip()) }) }) }); + createSystemRoleTree(), + createDataCenterRoleTree(), + createNetworkRoleTree(), + createStorageDomainRoleTree(), + createClusterRoleTree(), + createGlusterRoleTree(), + createHostRoleTree(), + createTemplateRoleTree(), + createVmRoleTree(), + createVmPoolRoleTree(), + createDiskRoleTree() }); // nothing to filter if (!ApplicationModeHelper.getUiMode().equals(ApplicationMode.AllModes)) { @@ -414,4 +86,198 @@ } return tree; } + + protected static RoleNode createDiskRoleTree() { + return new RoleNode(getConstants().diskRoleTree(), + new RoleNode[] { new RoleNode(getConstants().provisioningOperationsRoleTree(), + getConstants().notePermissionsContainingOperationsRoleTreeTooltip(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_DISK, getConstants().allowToCreateDiskRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_DISK, getConstants().allowToDeleteDiskRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_DISK_STORAGE, + getConstants().allowToMoveDiskToAnotherStorageDomainRoleTreeTooltip()), + new RoleNode(ActionGroup.ATTACH_DISK, + getConstants().allowToAttachDiskToVmRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_DISK_PROPERTIES, + getConstants().allowToChangePropertiesOfTheDiskRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_SCSI_GENERIC_IO, + getConstants().allowToChangeSGIORoleTreeTooltip()), + new RoleNode(ActionGroup.ACCESS_IMAGE_STORAGE, + getConstants().allowAccessImageDomainRoleTreeTooltip()) }) }); + } + + protected static RoleNode createVmPoolRoleTree() { + return new RoleNode(getConstants().vmPoolRoleTree(), new RoleNode[] { + new RoleNode(getConstants().basicOperationsRoleTree(), + new RoleNode[] { new RoleNode(ActionGroup.VM_POOL_BASIC_OPERATIONS, + getConstants().allowToRunPauseStopVmFromVmPoolRoleTreeTooltip()) }), + new RoleNode(getConstants().provisioningOperationsRoleTree(), + getConstants().notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_VM_POOL, + getConstants().allowToCreateVmPoolRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_VM_POOL, + getConstants().allowToDeleteVmPoolRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_VM_POOL_CONFIGURATION, + getConstants().allowToChangePropertiesOfTheVmPoolRoleTreeTooltip()) }) }); + } + + protected static RoleNode createVmRoleTree() { + return new RoleNode(getConstants().vmRoleTree(), + new RoleNode[] { + new RoleNode(getConstants().basicOperationsRoleTree(), new RoleNode[] { + new RoleNode(ActionGroup.VM_BASIC_OPERATIONS, + getConstants().allowBasicVmOperationsRoleTreeTooltip()), + new RoleNode(ActionGroup.CHANGE_VM_CD, + getConstants().allowToAttachCdToTheVmRoleTreeTooltip()), + new RoleNode(ActionGroup.CONNECT_TO_VM, + getConstants().allowViewingTheVmConsoleScreenRoleTreeTooltip()) }), + new RoleNode(getConstants().provisioningOperationsRoleTree(), + getConstants().notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), + new RoleNode[] { + new RoleNode(ActionGroup.EDIT_VM_PROPERTIES, + getConstants().allowChangeVmPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.CREATE_VM, + getConstants().allowToCreateNewVmsRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_VM, + getConstants().allowToRemoveVmsFromTheSystemRoleTreeTooltip()), + new RoleNode(ActionGroup.IMPORT_EXPORT_VM, + getConstants().allowImportExportOperationsRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_VM_STORAGE, + getConstants().allowToAddRemoveDiskToTheVmRoleTreeTooltip()), + new RoleNode(ActionGroup.MANIPULATE_VM_SNAPSHOTS, + getConstants().allowToCreateDeleteSnapshotsOfTheVmRoleTreeTooltip()) }), + new RoleNode(getConstants().administrationOperationsRoleTree(), + getConstants().notePermissionsContainigTheseOperationsShuoldAssociatDcOrEqualRoleTreeTooltip(), + new RoleNode[] { + new RoleNode(ActionGroup.MOVE_VM, + getConstants().allowToMoveVmImageToAnotherStorageDomainRoleTreeTooltip()), + new RoleNode(ActionGroup.MIGRATE_VM, + getConstants().allowMigratingVmBetweenHostsInClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.CHANGE_VM_CUSTOM_PROPERTIES, + getConstants().allowToChangeVmCustomPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_ADMIN_VM_PROPERTIES, + getConstants().allowChangingVmAdminPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.RECONNECT_TO_VM, + getConstants().allowReconnectToVmRoleTreeTooltip()) }) }); + } + + protected static RoleNode createTemplateRoleTree() { + return new RoleNode(getConstants().templateRoleTree(), new RoleNode[] { + new RoleNode(getConstants().basicOperationsRoleTree(), + new RoleNode[] { new RoleNode(ActionGroup.EDIT_TEMPLATE_PROPERTIES, + getConstants().allowToChangeTemplatePropertiesRoleTreeTooltip()) }), + new RoleNode(getConstants().provisioningOperationsRoleTree(), + getConstants().notePermissionsContainigTheseOperationsShuoldAssociatSdOrAboveRoleTreeTooltip(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_TEMPLATE, + getConstants().allowToCreateNewTemplateRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_TEMPLATE, + getConstants().allowToRemoveExistingTemplateRoleTreeTooltip()), + new RoleNode(ActionGroup.IMPORT_EXPORT_VM, + getConstants().allowImportExportOperationsRoleTreeTooltip()), + new RoleNode(ActionGroup.COPY_TEMPLATE, + getConstants().allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip()) }), + + new RoleNode(getConstants().administrationOperationsRoleTree(), + getConstants().notePermissionsContainigTheseOperationsShuoldAssociatDcOrEqualRoleTreeTooltip(), + new RoleNode[] { new RoleNode(ActionGroup.EDIT_ADMIN_TEMPLATE_PROPERTIES, + getConstants().allowChangingTemplateAdminPropertiesRoleTreeTooltip()) }) }); + } + + private static UIConstants getConstants() { + return ConstantsManager.getInstance().getConstants(); + } + + protected static RoleNode createHostRoleTree() { + return new RoleNode(getConstants().hostRoleTree(), new RoleNode(getConstants().configureHostRoleTree(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_HOST, + getConstants().allowToAddNewHostToTheClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_HOST, + getConstants().allowToRemoveExistingHostFromTheClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_HOST_CONFIGURATION, + getConstants().allowToEditHostPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.MANIPUTLATE_HOST, + getConstants().allowToChangeHostStatusRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_HOST_NETWORK, + getConstants().allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip()) })); + } + + protected static RoleNode createGlusterRoleTree() { + return new RoleNode(getConstants().glusterRoleTree(), new RoleNode(getConstants().configureVolumesRoleTree(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_GLUSTER_VOLUME, + getConstants().allowToCreateGlusterVolumesRoleTree()), + new RoleNode(ActionGroup.MANIPULATE_GLUSTER_VOLUME, + getConstants().allowToManipulateGlusterVolumesRoleTree()) })); + } + + protected static RoleNode createClusterRoleTree() { + return new RoleNode(getConstants().clusterRoleTree(), new RoleNode(getConstants().configureClusterRoleTree(), + new RoleNode[] { + new RoleNode(ActionGroup.CREATE_CLUSTER, + getConstants().allowToCreateNewClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_CLUSTER, getConstants().allowToRemoveClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_CLUSTER_CONFIGURATION, + getConstants().allowToEditClusterPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_CLUSTER_NETWORK, + getConstants().allowToEditLogicalNetworksForTheClusterRoleTreeTooltip()) })); + } + + protected static RoleNode createStorageDomainRoleTree() { + return new RoleNode(getConstants().storageDomainRoleTree(), + new RoleNode(getConstants().configureStorageDomainRoleTree(), new RoleNode[] { + new RoleNode(ActionGroup.CREATE_STORAGE_DOMAIN, + getConstants().allowToCreateStorageDomainRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_STORAGE_DOMAIN, + getConstants().allowToDeleteStorageDomainRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_STORAGE_DOMAIN_CONFIGURATION, + getConstants().allowToModifyStorageDomainPropertiesRoleTreeTooltip()), + new RoleNode(ActionGroup.MANIPULATE_STORAGE_DOMAIN, + getConstants().allowToChangeStorageDomainStatusRoleTreeTooltip()) })); + } + + protected static RoleNode createNetworkRoleTree() { + return new RoleNode(getConstants().networkRoleTree(), + new RoleNode[] { new RoleNode(getConstants().configureNetworkRoleTree(), new RoleNode[] { + new RoleNode(ActionGroup.CREATE_STORAGE_POOL_NETWORK, + getConstants().allowToCreateLogicalNetworkPerDataCenterRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, + getConstants().allowToEditLogicalNetworkRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_STORAGE_POOL_NETWORK, + getConstants().allowToDeleteLogicalNetworkRoleTreeTooltip()), + new RoleNode(ActionGroup.ASSIGN_CLUSTER_NETWORK, + getConstants().allowToAddRemoveLogicalNetworksForTheClusterRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_VM_NETWORK, + getConstants().allowToConfigureVMsNetworkRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_TEMPLATE_NETWORK, + getConstants().allowToConfigureTemlateNetworkRoleTreeTooltip()) }) }); + } + + protected static RoleNode createDataCenterRoleTree() { + return new RoleNode(getConstants().dataCenterRoleTree(), + new RoleNode(getConstants().configureDataCenterRoleTree(), new RoleNode[] { + new RoleNode(ActionGroup.CREATE_STORAGE_POOL, + getConstants().allowToCreateDataCenterRoleTreeTooltip()), + new RoleNode(ActionGroup.DELETE_STORAGE_POOL, + getConstants().allowToRemoveDataCenterRoleTreeTooltip()), + new RoleNode(ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, + getConstants().allowToModifyDataCenterPropertiesRoleTreeTooltip()) })); + } + + protected static RoleNode createSystemRoleTree() { + return new RoleNode(getConstants().systemRoleTree(), + new RoleNode(getConstants().configureSystemRoleTree(), + new RoleNode[] { + new RoleNode(ActionGroup.MANIPULATE_USERS, + getConstants().allowToAddRemoveUsersFromTheSystemRoleTreeTooltip()), + new RoleNode(ActionGroup.MANIPULATE_PERMISSIONS, + getConstants().allowToAddRemovePermissionsForUsersOnObjectsInTheSystemRoleTreeTooltip()), + new RoleNode(ActionGroup.MANIPULATE_ROLES, + getConstants().allowToDefineConfigureRolesInTheSystemRoleTreeTooltip()), + new RoleNode(ActionGroup.LOGIN, getConstants().allowToLoginToTheSystemRoleTreeTooltip()), + new RoleNode(ActionGroup.CONFIGURE_ENGINE, + getConstants().allowToGetOrSetSystemConfigurationRoleTreeTooltip()) })); + } } -- To view, visit http://gerrit.ovirt.org/19525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
