Itamar Heim has submitted this change and it was merged. Change subject: engine: Split update of 'isPlugged' and 'bootOrder' properties... ......................................................................
engine: Split update of 'isPlugged' and 'bootOrder' properties... HotPlugDiskToVmCommand updates 'isPlugged' and 'bootOrder' of all devices attached to any particular VM. It should only update 'isPlugged' for the device that was plugged by this command, otherwise it can cause a race with another thread which handles the hot plug of another disk for the same VM. Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Bug-Url: https://bugzilla.redhat.com/1003649 Signed-off-by: Sergey Gotliv <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M packaging/dbscripts/vm_device_sp.sql 6 files changed, 89 insertions(+), 31 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
