Noam Slomianko has posted comments on this change.
Change subject: webadmin: Disable + sign in custom properties
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
Line 67: panel.add(keyValueLineWidget);
Line 68: keyValueLineWidget.edit(keyValueLineModel);
Line 69: keyValueLineWidget.setEnabled(enabled);
Line 70:
Line 71: if (list.size() == 1 && object.keysUsedCount() == 0) {
What if it has only one property?
then size=1 && keysUsed=1 -> we still want the - sign to exist so they can
remove this value
Line 72: keyValueLineWidget.setMinusButtonEnabled(false);
Line 73: }
Line 74: if (list.size() == object.possibleKeysCount()) {
Line 75: keyValueLineWidget.setPlusButtonEnabled(false);
--
To view, visit http://gerrit.ovirt.org/19452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
