Lior Vernia has posted comments on this change.
Change subject: webadmin: Vnic hotplug validation - Patch 2 of 2
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Awesome job man, just one more comment about the naming of a method, otherwise
looks great.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 158: * The user may also plug and unplug interfaces when the VM is
down (regardless of hotplug support)
Line 159: * or create an unplugged NIC in a running VM when there isn't
support for hotplug.
Line 160: * @return an boolean.
Line 161: */
Line 162: public boolean allowHotPlug() {
Sorry for changing my mind, but I think allowPlug() might actually be a better
name, since if the VM is down then it's not "hot" plugging. So would be more
understandable without reading the javadoc.
Line 163: return hotPlugSupported ||
getVmStatus().equals(VMStatus.Down);
Line 164: }
Line 165:
Line 166: public Version getClusterCompatibilityVersion() {
--
To view, visit http://gerrit.ovirt.org/19189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
