Yair Zaslavsky has posted comments on this change. Change subject: engine : User is not able to see newly added permissions on object if he inherited this permission on that object ......................................................................
Patch Set 1: (3 comments) Please add dao tests. Kinda strange we don't have that at user portal already. Can you elaborate how it works in web admin? .................................................... File packaging/dbscripts/multi_level_administration_sp.sql Line 470: Line 471: Line 472: Create or replace FUNCTION GetAllUsersWithPermissionsOnEntityByEntityId(v_id UUID, v_user_id UUID, v_is_filtered BOOLEAN) Line 473: RETURNS SETOF permissions_view STABLE Line 474: -- SET NOCOUNT ON added to prevent extra result sets from not needed comment. Line 475: -- interfering with SELECT statements. Line 476: AS $procedure$ Line 477: BEGIN Line 478: RETURN QUERY SELECT * Line 475: -- interfering with SELECT statements. Line 476: AS $procedure$ Line 477: BEGIN Line 478: RETURN QUERY SELECT * Line 479: FROM permissions_view Can we use here the internal permissions view? Line 480: WHERE object_id = v_id Line 481: AND (NOT v_is_filtered OR EXISTS (SELECT 1 Line 482: FROM GetAllUsersWithPermissionsByEntityId(v_id, v_user_id, v_is_filtered))); Line 483: END; $procedure$ Line 504: Line 505: Line 506: Create or replace FUNCTION GetAllUsersWithPermissionsByEntityId(v_id UUID, v_user_id UUID, v_is_filtered BOOLEAN) Line 507: RETURNS SETOF permissions_view STABLE Line 508: -- SET NOCOUNT ON added to prevent extra result sets from this comment is not needed. Line 509: -- interfering with SELECT statements. Line 510: AS $procedure$ Line 511: BEGIN Line 512: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/19377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f8f8b110c41665bb6efe2647b654b845d70b7de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
