Sandro Bonazzola has posted comments on this change. Change subject: sos: engine: add jboss stack trace ......................................................................
Patch Set 1: -Code-Review (1 comment) .................................................... File src/sos/plugins/engine.py Line 8: Line 9: # Class name must be the same as file name and method names must not change Line 10: class engine(sos.plugintools.PluginBase): Line 11: """oVirt related information""" Line 12: sadly, ENGINE_UP_MARK contains only the engine pid, not the jboss pid. So if I use that I'll kill the engine process. I think that using pgrep here is the only way for having the right pid. Line 13: optionList = [ Line 14: ( Line 15: 'jbosstrace', Line 16: 'Enable oVirt Engine JBoss stack trace generation', -- To view, visit http://gerrit.ovirt.org/19365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id049f1cc7f322995a8692562a3f7aebddc7cc04d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
