Lior Vernia has uploaded a new change for review. Change subject: webadmin: Override getEntity() in HostSetupNetworksModel ......................................................................
webadmin: Override getEntity() in HostSetupNetworksModel It always returns VDS, so no reason to cast every time it's called. Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/19581/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java index c74d0b2..feefc10 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java @@ -55,6 +55,11 @@ */ public class HostSetupNetworksModel extends EntityModel { + @Override + public VDS getEntity() { + return (VDS) super.getEntity(); + } + private EntityModel privateCheckConnectivity; public EntityModel getCheckConnectivity() @@ -655,7 +660,7 @@ } }; - VDS vds = (VDS) getEntity(); + VDS vds = getEntity(); Frontend.RunQuery(VdcQueryType.GetVdsFreeBondsByVdsId, new IdQueryParameters(vds.getId()), asyncQuery); } @@ -676,7 +681,7 @@ } }; - VDS vds = (VDS) getEntity(); + VDS vds = getEntity(); IdQueryParameters params = new IdQueryParameters(vds.getId()); params.setRefresh(false); Frontend.RunQuery(VdcQueryType.GetVdsInterfacesByVdsId, params, asyncQuery); @@ -700,7 +705,7 @@ } }; - VDS vds = (VDS) getEntity(); + VDS vds = getEntity(); AsyncDataProvider.getClusterNetworkList(asyncQuery, vds.getVdsGroupId()); } @@ -785,7 +790,7 @@ params.setInterfaces(model.getAllNics()); params.setCheckConnectivity((Boolean) model.getCheckConnectivity().getEntity()); params.setConectivityTimeout((Integer) model.getConnectivityTimeout().getEntity()); - params.setVdsId(((VDS) getEntity()).getId()); + params.setVdsId(getEntity().getId()); params.setNetworksToSync(model.getNetworksToSync()); model.startProgress(null); @@ -799,7 +804,7 @@ EntityModel commitChanges = model.getCommitChanges(); if ((Boolean) commitChanges.getEntity()) { - new SaveNetworkConfigAction(sourceListModel, model, (VDS) getEntity()).execute(); + new SaveNetworkConfigAction(sourceListModel, model, getEntity()).execute(); } else { -- To view, visit http://gerrit.ovirt.org/19581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
