Juan Hernandez has posted comments on this change. Change subject: packaging: support modifying java module path ......................................................................
Patch Set 3: In a system with a packaging system like RPM the administrator can (and should) easily check what files have been changed before performing an update of a package, for example, if she is going to update the ovirt-engine package she should before verify it: # rpm -V ovirt-engine S.5....T. c /etc/ovirt-engine/engine.conf S.5....T. /usr/share/java/ovirt-engine/common.jar The result of this is already included in SOS reports. In this case this clearly shows that the configuration has been changed (which is expected) and that the common.jar file has been changed. The administrator knows now that the common.jar file will be overwritten by the update, so any changes she did will be lost. Then she will perform the update and after that she will check if the change is still needed and do it again if required. So if the administrator replaces a file it just has to be aware of this tool. This is day to day work of every system administrator (of RPM based systems, I guess it is similar for other packaging systems). Shading the module means that the administrator has to know how to create the modified module, has to remember in some ad-hoc way that she did so (usual system tools, like rpm -V won't tell she), and then, after performing the upgrade she will anyhow have to check if the change is still needed and remove it if not required. So, in my subjective opinion, the alternative to replace the file only requires common system administration knowledge, while shading the module requires specialized knowledge for no benefit. -- To view, visit http://gerrit.ovirt.org/19586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda53f67fa801cf4eb00b11483e9a6ab712d4d74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
