Tomas Jelinek has posted comments on this change.

Change subject: UI: support multi monitory only for cluster 3.3 and up
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1751:         getBehavior().updateDefaultTimeZone();
Line 1752:         if (getSelectedCluster() != null) {
Line 1753:         getIsSingleQxlEnabled().setEntity(getIsLinuxOS() &&
Line 1754:                 
Version.v3_3.compareTo(getSelectedCluster().getcompatibility_version()) <= 0);
Line 1755:         }
btw is it enough to set the entity (e.g. the default)? Don't you need to also 
set the setIsChangable accordingly (e.g. not possible to modify)?
Line 1756:         else {
Line 1757:             getIsSingleQxlEnabled().setEntity(false);
Line 1758:         }
Line 1759:     }


-- 
To view, visit http://gerrit.ovirt.org/19468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to