Vojtech Szocs has posted comments on this change.
Change subject: core, webadmin, restapi: Detach password from VdcUser
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
Line 779: public void onSuccess(final VdcReturnValueBase result) {
Line 780: logger.finer("Succesful returned result from
Login."); //$NON-NLS-1$
Line 781: setLoggedInUser(null);
Line 782: callback.getDel().onSuccess(callback.getModel(),
result);
Line 783: setLoginPassword(null);
I assume this is to keep getLoggedInUser vs. getLoginPassword in sync, due to
the password now being stored separately.
In order to stay consistent, you should call setLoginPassword right after each
call to setLoggedInUser.
Line 784: if (getLoginHandler() != null &&
result.getSucceeded()) {
Line 785: getLoginHandler().onLoginSuccess(userName,
password, domain);
Line 786: }
Line 787: }
--
To view, visit http://gerrit.ovirt.org/17096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab9321816ee28355a4118910086891f5a552014
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
