Greg Padgett has posted comments on this change.
Change subject: packaging: setup: require answer file on additional hosts
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Code looks good, just a few wording suggestions.
....................................................
File src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py
Line 225: )
Line 226: def _customization(self):
Line 227: self.logger.warning(
Line 228: _(
Line 229: 'Any configuration file was supplied while deploying '
IIUC, perhaps it should be something like "A configuration file must be
supplied to deploy Hosted Engine on an additional host."
Line 230: 'Hosted Engine on an additional host.'
Line 231: )
Line 232: )
Line 233:
Line 239: ohostedcons.FirstHostEnv.FETCH_ANSWER
Line 240: ] = self.dialog.queryString(
Line 241: name='OVEHOSTED_CORE_FETCH_ANSWER',
Line 242: note=_(
Line 243: 'Do you want to scp the answer file from first
host? '
It doesn't look optional, but maybe I'm not understanding the flow. Is there a
way to work around it? If it really is required, the prompt may be better as
continue/cancel, or as yes/no with a note that answering "no" does not lead to
prosperity.
Line 244: '(@VALUES@)[@DEFAULT@]: '
Line 245: ),
Line 246: prompt=True,
Line 247: validValues=(_('Yes'), _('No')),
Line 251:
Line 252: if not
self.environment[ohostedcons.FirstHostEnv.FETCH_ANSWER]:
Line 253: raise RuntimeError(
Line 254: _(
Line 255: 'Cannot deploy Hosted Engine on additional host '
"Cannot deploy Hosted Engine on additional hosts without access to the
configuration used on the first host" ?
Line 256: 'without knowing the configuration used on first
host'
Line 257: )
Line 258: )
Line 259:
--
To view, visit http://gerrit.ovirt.org/19577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8fd38828422c52c416ad3125c2e39193956d74f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
