Greg Padgett has posted comments on this change.
Change subject: packaging: setup: validate host id
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/storage/storage.py
Line 218: ] in all_host_stats.keys():
Line 219: valid = False
Line 220: if interactive:
Line 221: self.logger.error(
Line 222: _('Invalid value for Host ID: already
used')
We may want to consider a way to bypass the error in case of e.g. re-deployment
on an additional host that was previously set up.
Line 223: )
Line 224: else:
Line 225: raise RuntimeError(
Line 226: _('Invalid value for Host ID: already
used')
--
To view, visit http://gerrit.ovirt.org/19171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2487abfe1f722cb60e6f7c2a8daa4a81fb654bfd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Leonid Natapov <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
