Sahina Bose has posted comments on this change.
Change subject: gluster: Introduced GlusterTaskUtils
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 5: import org.ovirt.engine.core.common.job.JobExecutionStatus;
Line 6:
Line 7: public class GlusterTaskUtils {
Line 8:
Line 9: public static boolean isTaskOfType(GlusterVolumeEntity volume,
GlusterTaskType type) {
Do you need a util class for these methods? Shouldn't these methods belong in
GlusterVolumeEntity class?
Line 10: if (volume.getAsyncTask() != null &&
volume.getAsyncTask().getType() == type) {
Line 11: return true;
Line 12: }
Line 13:
--
To view, visit http://gerrit.ovirt.org/19507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58610601c64f16796962d0ebf8643fa591b82e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
