Sahina Bose has posted comments on this change.
Change subject: restapi: REST api for start remove brick/bricks of a gluster
volume
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Is this patch really required? The existing remove works, AFAIK
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java
Line 58: * @return
Line 59: */
Line 60: @DELETE
Line 61: @Path("{brick_id}")
Line 62: public Response startRemove(@PathParam("brick_id") String id);
I agree with Shubhendu. Method name should be remove
Line 63:
Line 64: /**
Line 65: * Sub-resource locator method, returns individual
GlusterBrickResource on which the remainder of the URI is
Line 66: * dispatched.
--
To view, visit http://gerrit.ovirt.org/19358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I786bec796ad7305defa93e74b6ecaa24b61870b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
