Tomas Jelinek has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 4:
(6 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 413:
getParameters().getMasterVm().getMinAllocatedMem(),
Line 414: getParameters().getMasterVm().isStateless(),
Line 415: getParameters().getMasterVm().isRunAndPause(),
Line 416: getUserId(),
Line 417: getVdsGroup().getArchitecture()));
not needed anymore
Line 418:
getVmTemplate().setAutoStartup(getParameters().getMasterVm().isAutoStartup());
Line 419:
getVmTemplate().setPriority(getParameters().getMasterVm().getPriority());
Line 420:
getVmTemplate().setDefaultDisplayType(getParameters().getMasterVm().getDefaultDisplayType());
Line 421:
getVmTemplate().setInitrdUrl(getParameters().getMasterVm().getInitrdUrl());
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
Line 169: .addValue("vnc_keyboard_layout",
template.getVncKeyboardLayout())
Line 170: .addValue("min_allocated_mem",
template.getMinAllocatedMem())
Line 171: .addValue("is_run_and_pause",
template.isRunAndPause())
Line 172: .addValue("created_by_user_id",
template.getCreatedByUserId())
Line 173: .addValue("architecture", template.getArchitecture());
this is not present on the stored procedure so this should be removed as well..
Line 174: }
Line 175:
Line 176: @Override
Line 177: public void update(VmTemplate template) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
Line 445: template.setMemSizeMb((Integer)
model.getMemSize().getEntity());
Line 446: template.setMinAllocatedMem(((Integer)
model.getMinAllocatedMemory().getEntity()));
Line 447:
Line 448: template.setVdsGroupId((model.getSelectedCluster()).getId());
Line 449:
template.setArchitecture((model.getSelectedCluster()).getArchitecture());
this can be removed
Line 450: template.setTimeZone((model.getTimeZone().getIsAvailable() &&
model.getTimeZone().getSelectedItem() != null) ? ((TimeZoneModel)
model.getTimeZone()
Line 451: .getSelectedItem()).getTimeZoneKey()
Line 452: : ""); //$NON-NLS-1$
Line 453: template.setNumOfSockets((Integer)
model.getNumOfSockets().getSelectedItem());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 1379: tempVar.setKernelParams(vm.getKernelParams());
Line 1380: tempVar.setDedicatedVmForVds(vm.getDedicatedVmForVds());
Line 1381: tempVar.setMigrationSupport(vm.getMigrationSupport());
Line 1382: tempVar.setVncKeyboardLayout(vm.getVncKeyboardLayout());
Line 1383: tempVar.setArchitecture(vm.getArchitecture());
not needed here
Line 1384:
Line 1385: VM newvm = tempVar;
Line 1386:
Line 1387: EntityModel displayProtocolSelectedItem = (EntityModel)
model.getDisplayProtocol().getSelectedItem();
Line 1950: getcurrentVm().setVmMemSizeMb((Integer)
model.getMemSize().getEntity());
Line 1951: getcurrentVm().setMinAllocatedMem((Integer)
model.getMinAllocatedMemory().getEntity());
Line 1952: Guid newClusterID = model.getSelectedCluster().getId();
Line 1953: getcurrentVm().setVdsGroupId(newClusterID);
Line 1954:
getcurrentVm().setArchitecture(model.getSelectedCluster().getArchitecture());
not needed here
Line 1955:
getcurrentVm().setTimeZone((model.getTimeZone().getIsAvailable() &&
model.getTimeZone().getSelectedItem() != null) ? ((TimeZoneModel)
model.getTimeZone()
Line 1956: .getSelectedItem()).getTimeZoneKey()
Line 1957: : ""); //$NON-NLS-1$
Line 1958: getcurrentVm().setNumOfSockets((Integer)
model.getNumOfSockets().getSelectedItem());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
Line 596: getcurrentVm().setVmMemSizeMb((Integer)
model.getMemSize().getEntity());
Line 597: getcurrentVm().setMinAllocatedMem((Integer)
model.getMinAllocatedMemory().getEntity());
Line 598: Guid newClusterID = model.getSelectedCluster().getId();
Line 599: getcurrentVm().setVdsGroupId(newClusterID);
Line 600:
getcurrentVm().setArchitecture(model.getSelectedCluster().getArchitecture());
not needed here
Line 601: getcurrentVm().setTimeZone(
Line 602: (model.getTimeZone().getIsAvailable() &&
model.getTimeZone().getSelectedItem() != null) ?
Line 603: ((TimeZoneModel)
model.getTimeZone().getSelectedItem()).getTimeZoneKey() : ""); //$NON-NLS-1$
Line 604: getcurrentVm().setNumOfSockets((Integer)
model.getNumOfSockets().getSelectedItem());
--
To view, visit http://gerrit.ovirt.org/18938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
