anmolbabu has posted comments on this change.

Change subject: webadmin : Show yellow up arrow when one or more bricks of a 
volume are down
......................................................................


Patch Set 1:

(5 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-09-27 14:36:00 +0530
Line 4: Commit:     Anmol Babu <[email protected]>
Line 5: CommitDate: 2013-09-27 14:39:33 +0530
Line 6: 
Line 7: webadmin : Show yellow up arrow when one or more bricks of a volume are 
down
Done
Line 8: 
Line 9: Show yellow up arrow when one or more bricks of a volume are down
Line 10: 
Line 11: Signed-off-by: Anmol Babu <[email protected]>


....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 1528:     @DefaultStringValue("Down")
Line 1529:     String down();
Line 1530: 
Line 1531:     @DefaultStringValue("One or more bricks are down!!!")
Line 1532:     String brickWarning();
Done
Line 1533: 
Line 1534:     @DefaultStringValue("Powering Up")
Line 1535:     String poweringUp();
Line 1536: 


....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
Line 239:     @Source("images/comboBoxDropDownIcon.png")
Line 240:     ImageResource comboBoxDropDownIcon();
Line 241: 
Line 242:     @Source("images/Arrow_Up_Yellow.png")
Line 243:     ImageResource volumeBrickWarning();
Done


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java
Line 34:         GlusterStatus status = volume.getStatus();
Line 35:         ImageResource statusImage = null;
Line 36:         String tooltip;
Line 37: 
Line 38:         Boolean brickWarn = false;
Done
Line 39: 
Line 40:         for(GlusterBrickEntity brick : volume.getBricks()) {
Line 41:             if(brick.getStatus() == GlusterStatus.DOWN) {
Line 42:                 brickWarn = true;


Line 37: 
Line 38:         Boolean brickWarn = false;
Line 39: 
Line 40:         for(GlusterBrickEntity brick : volume.getBricks()) {
Line 41:             if(brick.getStatus() == GlusterStatus.DOWN) {
Done
Line 42:                 brickWarn = true;
Line 43:             }
Line 44:         }
Line 45: 


-- 
To view, visit http://gerrit.ovirt.org/19611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to