Sergey Gotliv has posted comments on this change.
Change subject: core: Disk hotplug validation - Patch 1 of 2
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 178:
Line 179: List<String> diskHotpluggableInterfaces =
osRepository.getDiskHotpluggableInterfaces(getVm().getOs(),
Line 180: getVm().getVdsGroupCompatibilityVersion());
Line 181: if (diskHotpluggableInterfaces == null ||
diskHotpluggableInterfaces.isEmpty()) {
Line 182: retVal = false;
Please, use CollectionUtils.isEmpty() which validates both nullness and
emptyness.
See example in CloudInitHandler.
Line 183: }
Line 184:
Line 185: if (retVal) {
Line 186: Collection<DiskInterface> diskInterfaces = new
HashSet<DiskInterface>();
Line 181: if (diskHotpluggableInterfaces == null ||
diskHotpluggableInterfaces.isEmpty()) {
Line 182: retVal = false;
Line 183: }
Line 184:
Line 185: if (retVal) {
If you refactoring this method anyway, consider to use:
return failCanDoAction...
Its hard to follow after retVal
Line 186: Collection<DiskInterface> diskInterfaces = new
HashSet<DiskInterface>();
Line 187: for (String diskHotpluggableInterface :
diskHotpluggableInterfaces) {
Line 188:
diskInterfaces.add(DiskInterface.valueOf(diskHotpluggableInterface));
Line 189: }
--
To view, visit http://gerrit.ovirt.org/19601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e4c792b607429daf077c11820b43f171d376b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
