Lior Vernia has posted comments on this change.
Change subject: webadmin: Vnic hotplug validation - Patch 2 of 2
......................................................................
Patch Set 10:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
Line 271: String providerUrlWarningText(String providedEntities);
Line 272:
Line 273: // Vnic
Line 274: @DefaultMessage("The VM is not down, and NIC Hot Plug is not
supported on cluster version {0}.")
Line 275: String nicHotPlugNotSupported(String clusterVersion);
If I understand the usage of the dialog correctly, the same widget is used for
both "hot" and "cold" plugging. So if the plug widget is disabled, the reason
is that the VM isn't down (otherwise it would have been enabled on the basis of
it being "cold" plugging) AND that hot plugging isn't supported.
Line 276:
Line 277: @DefaultMessage("Updating 'profile' on a running virtual machine
while the NIC is plugged is not supported on cluster version {0}")
Line 278: String hotProfileUpdateNotSupported(String clusterVersion);
Line 279:
--
To view, visit http://gerrit.ovirt.org/19189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
