Ori Liel has posted comments on this change.

Change subject: restapi: Resource interfaces for Gluster Volume(s)
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
Line 20:  */
I still need to get back to you about this modelling, I've contacted our PM and 
waiting for his response.

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumesResource.java
Line 37:      */
There's another place where we document mandatory and optional arguments for 
REST operations: 
restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml. This 
meta-data file is used to create the RSDL - the rest-api descriptor, which can 
be accessed at: http://{host:port}/api?rsdl and shows everything that the API 
is capable of. 

Please add documentation for this, and all other methds, to this file. You can 
look at the file to see examples, and I'm here for any question (the yaml file 
can be a bit confusing, don't hesitate to ask)

--
To view, visit http://gerrit.ovirt.org/3364
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97503702a4fc5eeedeaa44ad1aba7cd35919521a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to