Oved Ourfali has posted comments on this change.
Change subject: WIP core: adding a filter policy for CPU level
......................................................................
Patch Set 1:
(2 comments)
Should I add it to ALL existing build-in policies?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java
Line 26: if (compareResult >= 0) {
Line 27: hostsToRunOn.add(host);
Line 28: } else {
Line 29:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_CPU_LEVEL.toString());
Line 30: log.debugFormat("Host {0} has CPU level ({1})
which is lower than the CPU level the VM was run with ({2})",
You're right. The code needs to be fixed. Needs to be lower or equal 0 and not
higher or equal.
Line 31: host.getName(),
Line 32: host.getCpuName(),
Line 33: vm.getCpuName());
Line 34: }
Line 33: vm.getCpuName());
Line 34: }
Line 35: }
Line 36:
Line 37: return hostsToRunOn;
I'll add a debug format for all selected hosts as well.
Line 38: } else {
Line 39: return hosts;
Line 40: }
Line 41: }
--
To view, visit http://gerrit.ovirt.org/19563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42b803fe0d2e9389d10196cd44c3fd21342927f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
