Tal Nisan has posted comments on this change.
Change subject: engine: Display correct and user friendly size of iso files
......................................................................
Patch Set 1:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 576: // cannot determine the correct size of the iso file.
Line 577: if (isoFile.getValue().isEmpty() ||
!isoFile.getValue().containsKey("size")) {
Line 578: return 0;
Line 579: } else {
Line 580: return Long.valueOf(isoFile.getValue().get("size"));
You might want to catch NumberFormatException and return 0 also in case of a
wrong number format in the return value
Line 581: }
Line 582: }
Line 583:
Line 584: /**
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java
Line 14
Line 15
Line 16
Line 17
Line 18
Can never be null?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsoListReturnForXmlRpc.java
Line 5: import java.util.Map;
Line 6:
Line 7: public final class IsoListReturnForXmlRpc extends StatusReturnForXmlRpc
{
Line 8: private static final String ISO_LIST = "isolist";
Line 9: private static final String ISO_DICT = "isodict";
Make sure this complies with the name in the VDSM patch after you refer to the
comments there
Line 10:
Line 11: private Map<String, Map<String, String>> fileToMetadata;
Line 12:
Line 13: public IsoListReturnForXmlRpc(Map<String, Object> innerMap) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HsmGetIsoListVDSCommand.java
Line 13
Line 14
Line 15
Line 16
Line 17
Again, check if cannot be null for sure
--
To view, visit http://gerrit.ovirt.org/19549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
