Allon Mureinik has posted comments on this change.
Change subject: rest: VirtIO-SCSI enabled flag
......................................................................
Patch Set 6:
(1 comment)
1. see inline comment
2. did you handle the injection as per Michael's comment on patchset #5? I did
not see it, but I may have overlooked something.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
Line 14: public static VmHelper getInstance() {
Line 15: return instance;
Line 16: }
Line 17:
Line 18: public static List<String> getVirtioScsiControllersForEntity(Guid
id) {
ummm... is this is a singleton, should this simply be an instance method?
Line 19: return VmHelper.getInstance().getEntity(List.class,
Line 20: VdcQueryType.GetVirtioScsiControllers,
Line 21: new IdQueryParameters(id),
Line 22: "GetVirtioScsiControllers", true);
--
To view, visit http://gerrit.ovirt.org/19154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I481025152b20579ac615d9023ed0cef9b64558e1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
