Allon Mureinik has posted comments on this change.
Change subject: core: Move getFQN to SetVmTicketCommand
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
Line 56: }
Line 57: return permissions;
Line 58: }
Line 59:
Line 60: String getConsoleUserName() {
shouldn't this be private?
Line 61: VdcUser user = getCurrentUser();
Line 62: String domain = user.getDomainControler();
Line 63: String name = user.getUserName();
Line 64: if (StringUtils.isEmpty(name) || name.contains("@") ||
StringUtils.isEmpty(domain)) {
Line 58: }
Line 59:
Line 60: String getConsoleUserName() {
Line 61: VdcUser user = getCurrentUser();
Line 62: String domain = user.getDomainControler();
These two variables are only used in the else branch.
Perhaps it's worth the hassle moving them there.
Line 63: String name = user.getUserName();
Line 64: if (StringUtils.isEmpty(name) || name.contains("@") ||
StringUtils.isEmpty(domain)) {
Line 65: return name;
Line 66: } else {
--
To view, visit http://gerrit.ovirt.org/17223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a3a45136db9c42ab347f9722326f597afd26fd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
