Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: revert nfs config on cleanup
......................................................................
Patch Set 3:
(1 comment)
....................................................
File packaging/setup/ovirt_engine_setup/util.py
Line 52: """
Line 53: )
Line 54:
Line 55:
Line 56: def editConfigContent(content, params, changed_lines=[]):
the instance of the list used as initializer of default parameter is created
when python is loaded.
modifying it via code will cause 2nd call to initialize the default using the
modified list.
see the code example at my first comment.
as result, you cannot use default parameter initialization of list.
Line 57: newcontent = []
Line 58: for line in content:
Line 59: f = _RE_PARAM.match(line)
Line 60: if f is not None and f.group('param') in params:
--
To view, visit http://gerrit.ovirt.org/19001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
