Daniel Erez has posted comments on this change.
Change subject: webadmin: Display more accurate size of ISO files
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 73: if (sizeInGB == 0) {
Line 74: // sizeInGB = 0 means that Engine working with old VDSM
which doesn't return the correct size, so it
Line 75: // should display the size as 'less than 1 GB' for
backward compatibility
Line 76: return "< 1 GB"; //$NON-NLS-1$
Line 77: }
I guess it was done in order to format sizes <1GB ?
Maybe you can just move this logic to format method (i.e. check Format enum in
format method).
Line 78:
Line 79: NumberFormat fmt = NumberFormat.getFormat("####.##");
//$NON-NLS-1$
Line 80: if (sizeInGB >= 1) {
Line 81: return fmt.format(sizeInGB) + " GB"; //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/19550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
