Shubhendu Tripathi has posted comments on this change.
Change subject: engine: Gluster task monitoring for tasks started from CLI
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 127: return runningTasks;
Line 128: }
Line 129:
Line 130:
Line 131: private void createJobToMonitor(VDSGroup cluster,
GlusterAsyncTask task) {
Can we break this method in smaller and modular ones? Similar code is getting
executed again and again
Line 132: if (task.getStatus() != JobExecutionStatus.STARTED) {
Line 133: return; //there's no need to monitor jobs that are failed
or completed
Line 134: }
Line 135: StepEnum step = task.getType().getStep();
--
To view, visit http://gerrit.ovirt.org/19183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
