Omer Frenkel has posted comments on this change.
Change subject: core+ui: Support lowering cluster CPU level
......................................................................
Patch Set 2:
(2 comments)
generally look ok
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfActiveVmsInVdsGroupByVdsGroupIdQuery.java
Line 16: protected void executeQueryCommand() {
Line 17: List<VM> vms =
DbFacade.getInstance().getVmDao().getAllForVdsGroup(getParameters().getId());
Line 18:
Line 19: // Active VMs are VMs that aren't in Down status
Line 20: Integer activeVms = 0;
why not just primitive int ?
Line 21: for (VM vm : vms) {
Line 22: if (vm.getStatus() != VMStatus.Down) {
Line 23: ++activeVms;
Line 24: }
Line 22: if (vm.getStatus() != VMStatus.Down) {
Line 23: ++activeVms;
Line 24: }
Line 25: }
Line 26: getQueryReturnValue().setReturnValue(activeVms);
is it ok that the query counts suspended and image locked as not down as well?
Line 27: }
--
To view, visit http://gerrit.ovirt.org/19442
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
