Omer Frenkel has posted comments on this change.
Change subject: core: saving the cpu_name in vm_dynamic
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 2060: // we will add it to _vmDynamicToSave though because it
might been removed from it in #updateRepository
Line 2061: if (vm.getStatus() != VMStatus.Suspended &&
vm.getStatus() != VMStatus.Down) {
Line 2062:
ResourceManager.getInstance().InternalSetVmStatus(vm, VMStatus.Down,
exitStatus, exitMessage);
Line 2063: }
Line 2064: vm.getDynamicData().setCpuName(null);
please move it to resourceManager.resetVmAttributes
Line 2065: addVmDynamicToList(vm.getDynamicData());
Line 2066: addVmStatisticsToList(vm.getStatisticsData());
Line 2067: addVmInterfaceStatisticsToList(vm.getInterfaces());
Line 2068: if
(!ResourceManager.getInstance().IsVmInAsyncRunningList(vm.getId())) {
--
To view, visit http://gerrit.ovirt.org/19562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13891b3425e4864334851ecb12d1d61a162082
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
