Daniel Erez has posted comments on this change.
Change subject: webadmin: Only display gateway if feature supported
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 319:
networkDialogModel.getAddress().setEntity(entity.getAddress());
Line 320:
networkDialogModel.getSubnet().setEntity(entity.getSubnet());
Line 321:
networkDialogModel.getGateway().setEntity(entity.getGateway());
Line 322: networkDialogModel.startProgress(null);
Line 323:
AsyncDataProvider.isMultipleGatewaysSupported(getEntity().getVdsGroupCompatibilityVersion().getValue(),
no need for an async query, instead, just use:
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MultipleGatewaysSupported,
version);
Line 324: new AsyncQuery(this, new INewAsyncCallback() {
Line 325:
Line 326: @Override
Line 327: public void onSuccess(Object model, Object
returnValue) {
--
To view, visit http://gerrit.ovirt.org/19582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
