Mike Kolesnik has posted comments on this change.

Change subject: core: Permission filtering for GetTemplateInterfacesByTemplateId
......................................................................


Patch Set 2: (1 inline comment)

Basically +2, just 1 minor comment

....................................................
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
Line 105:         assertTrue(result.size() == 0);
Why not check isEmpty()?

--
To view, visit http://gerrit.ovirt.org/1902
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d63141be309be4c2b04cd7973a89961830afd7d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to