Vojtech Szocs has posted comments on this change. Change subject: userportal: Dynamic guide link ......................................................................
Patch Set 3: I made a typo again :-( correcting my previous comment: ... This explains the extra UserPortalPlaceManager binding within GIN-generated fragment: UserPortalConfigurator does @Inject UserPortalConfigurator, there is no binding for *UserPortalPlaceManager* type (only for PlaceManager), so Just-In-Time binding semantics apply to *UserPortalPlaceManager* [1]: bind(UserPortalPlaceManager.class); // implicit Just-In-Time binding ... Sorry for the typos! (at least you know I'm not a robot) -- To view, visit http://gerrit.ovirt.org/19298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
