Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Allowed non-draggable NetworkItemPanel
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Just a minor inline comment, looks good otherwise.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
Line 138:
Line 139: }, ContextMenuEvent.getType());
Line 140:
Line 141: // drag start
Line 142: addBitlessDomHandler(new DragStartHandler() {
Hm, maybe we can call addBitlessDomHandler only if draggable == true, i.e.
something like this:
if (draggable) {
addBitlessDomHandler(...);
}
I'm just wondering, how can DragStartEvent get triggered even after calling
getElement().setDraggable(DRAGGABLE_FALSE) - I'd expect drag events not to be
raised in that case.
Line 143: @Override
Line 144: public void onDragStart(DragStartEvent event) {
Line 145: if (!draggable) {
Line 146: return;
--
To view, visit http://gerrit.ovirt.org/19694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
