Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fixed table layout upon enableColumnResizing()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Just one minor comment, the patch looks good overall.
Thanks for fixing this issue! Before this patch, even after calling
enableColumnResizing() + adding columns with PX widths, column resize behavior
could get messed up in case caller didn't set "table-layout:fixed" on the table
widget.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
Line 281: * behavior will not function properly.</em>
Line 282: */
Line 283: public void enableColumnResizing() {
Line 284: columnResizingEnabled = true;
Line 285: setWidth("100%", true); //$NON-NLS-1$
I suggest to add a comment to explain this change, for example:
// Column resize implementation needs table-layout:fixed (disable
browser-specific table layout algorithm)
setWidth("100%", true); //$NON-NLS-1$
Line 286: }
Line 287:
Line 288: @Override
Line 289: public void onResizeStart(Column<T, ?> column, Element
headerElement) {
--
To view, visit http://gerrit.ovirt.org/19714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36d2d4f1cae395fe9f12d55a05799445d0eca11
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
