Piotr Kliczewski has posted comments on this change.
Change subject: Use FQDN from guest agent for RDP
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
Line 359: feature.setDescription("Ability to attach/detach storage
server connections to/from a specific storage domain (common use case: disaster
recovery).");
Line 360: features.getFeature().add(feature);
Line 361: }
Line 362:
Line 363: private void addFeatureReportVmFQDN(Features features) {
There are method looking exactly the same. I think that using common method for
all of them would be better idea than copying and pasting.
Line 364: Feature feature = new Feature();
Line 365: feature.setName("VM FQDN");
Line 366: feature.setDescription("Ability to report the fully qualified
domain name (FQDN) of a Virtual Machine");
Line 367: features.getFeature().add(feature);
--
To view, visit http://gerrit.ovirt.org/19748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
