Hello Yedidyah Bar David,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19779
to review the following change.
Change subject: core: Suppress dump of certain env keys
......................................................................
core: Suppress dump of certain env keys
Fix a bug in the code that was already meant to do that.
Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Signed-off-by: Yedidyah Bar David <[email protected]>
---
M ChangeLog
M src/otopi/context.py
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/otopi refs/changes/79/19779/1
diff --git a/ChangeLog b/ChangeLog
index 88d2b09..c13b86b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,7 @@
????-??-?? - Version 1.1.2
* network: firewalld: fix service deletion.
+ * core: fix suppress environment variable logic.
2013-09-07 - Version 1.1.1
diff --git a/src/otopi/context.py b/src/otopi/context.py
index c896d0f..afe2e2e 100644
--- a/src/otopi/context.py
+++ b/src/otopi/context.py
@@ -445,7 +445,9 @@
self.environment[key] != old.get(key)
):
value = self.environment[key]
- if key in constants.BaseEnv.SUPPRESS_ENVIRONMENT_KEYS:
+ if key in self.environment[
+ constants.BaseEnv.SUPPRESS_ENVIRONMENT_KEYS
+ ]:
value = '***'
self.logger.debug(
"ENV %s=%s:'%s'",
--
To view, visit http://gerrit.ovirt.org/19779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7148d6e7828a392b5b0b8391931685b40ed3a477
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
