Leonardo Bianconi has posted comments on this change.
Change subject: engine: VM Device Type for Display Type
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java
Line 2:
Line 3: import org.ovirt.engine.core.common.utils.VmDeviceType;
Line 4:
Line 5: public enum DisplayType {
Line 6: vnc(VmDeviceType.VGA),
We added VGA as default because both, x86_64 and ppc64, support it and ppc64
doesn't support cirrus. It's only for the default in the code, the OSInfo will
set the default VmDeviceType as cirrus for x86_64.
Line 7: qxl(VmDeviceType.QXL);
Line 8:
Line 9: private VmDeviceType defaultVmDeviceType;
Line 10:
....................................................
File packaging/conf/osinfo-defaults.properties
Line 46:
Line 47: os.other.devices.audio.value = ich6
Line 48: # See VmInterfaceType.java
Line 49: os.other.devices.network.value = rtl8139, e1000, pv
Line 50: os.other.displayProtocols.value = vnc/cirrus,qxl/qxl
We used qxl because it's the enum name (DisplayType), otherwise we should
change the enum name or create a map to find the correct enum. Do you think we
should change it?
Line 51:
Line 52: os.linux.id.value = 100
Line 53: os.linux.name.value = Linux
Line 54: os.linux.derivedFrom.value = other
--
To view, visit http://gerrit.ovirt.org/18677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326f8aaf0de95332436499205f90336d2f4e73d7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
