Yaniv Bronhaim has posted comments on this change.
Change subject: engine : Change VdsManager to use vdsDynamic instead of VDS
......................................................................
Patch Set 18:
(3 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java
Line 70: }
Line 71:
Line 72: @Override
Line 73: public void updateAllInBatch(Collection<T> entities) {
Line 74: if (entities != null && entities.size() > 0)
we use { even for one line in the scope. lets keep it
consider a report if null is passed.
Line 75: updateAllInBatch(getProcedureNameForUpdate(), entities,
getBatchMapper());
Line 76: }
Line 77:
Line 78: public abstract MapSqlParameterMapper<T> getBatchMapper();
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/GlusterMonitoringStrategy.java
Line 9: */
Line 10: public class GlusterMonitoringStrategy implements MonitoringStrategy {
Line 11:
Line 12: @Override
Line 13: public boolean canMoveToMaintenance(VDS vds) {
why keep passing all VDS ? also refer to processHardwareCapabilitiesNeeded.
can't you change it also in the interface?
Line 14: return canMoveToMaintenance(vds.getDynamicData());
Line 15: }
Line 16:
Line 17: @Override
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategy.java
Line 10: public interface MonitoringStrategy {
Line 11: /**
Line 12: * Check VDS hardware capabilities, and update VDS accordingly
Line 13: */
Line 14: public void processHardwareCapabilities(VDS vds);
change it, pass only vdsDynamic. all hardware info are stored there.
Line 15:
Line 16: /**
Line 17: * Check VDS hardware capabilities, and update VDS accordingly
Line 18: */
--
To view, visit http://gerrit.ovirt.org/17276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffeecde0541ce54a9297664b89fcedce301ba6fd
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
