Allon Mureinik has posted comments on this change.

Change subject: core: delete connections on block domain removal
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
Line 195:         List<StorageServerConnections> list = DbFacade.getInstance()
Line 196:                 
.getStorageServerConnectionDao().getAllForVolumeGroup(storageDomain.getStorage());
Line 197:         for (StorageServerConnections connection : 
FilterConnectionsUsedByOthers(list, storageDomain.getStorage())) {
Line 198:             
DbFacade.getInstance().getStorageServerConnectionDao().remove(connection.getid());
Line 199:         }
Add a comment:
// There is no need to remove entries from lun_storage_server_connection_map, 
as the foreign key from the luns table is defined as ON DELETE CASCADE.
Line 200:         removeStorageDomainLuns(storageDomain);
Line 201:         return true;
Line 202:     }
Line 203: 


-- 
To view, visit http://gerrit.ovirt.org/19753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to