Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
Patch Set 5:
(6 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 995
Line 996
Line 997
Line 998
Line 999
I think space should be before.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 80: self._parent = parent
Line 81: self._backup = None
Line 82: self.environment[
Line 83: osetupcons.RPMDistroEnv.VERSIONLOCK_MODIFIED
Line 84: ] = None
name suggests that it is boolean.
Line 85:
Line 86: def __str__(self):
Line 87: return _("Version Lock Transaction")
Line 88:
Line 294: osetupcons.RPMDistroEnv.REQUIRE_ROLLBACK,
Line 295: None
Line 296: )
Line 297: if self._distribution in ('redhat', 'fedora', 'centos'):
Line 298: self._enabled = True
this enabled should be only after no errors at all...
Line 299: self.command.detect('rpm')
Line 300:
Line 301: vlocktrans = self.VersionLockTransaction(
Line 302: parent=self,
Line 303: )
Line 304:
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 305: vlocktrans
Line 306: )
Line 307: vlocktrans.setup()
why don't you use the prepare? if required to be here, then it should not be
part of the transaction.
Line 308:
Line 309: from otopi import miniyum
Line 310: self._miniyum = miniyum
Line 311:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
Line 52
Line 53
Line 54
Line 55
Line 56
please do not perform operative logic in init
Line 49: )
Line 50: def _init(self):
Line 51: self.environment[
Line 52: osetupcons.CoreEnv.LEGACY_PG_CREDS_FOUND
Line 53: ] = None
name implies boolean
Line 54: if os.path.exists(
Line 55: osetupcons.FileLocations.LEGACY_PSQL_PASS_FILE
Line 56: ):
Line 57: self.logger.debug('Existing database pgpass found')
--
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
