Sergey Gotliv has posted comments on this change.
Change subject: backend: don't stop tasks on storagePoolUpEvent
......................................................................
Patch Set 1:
(1 comment)
Good cleanup!
I am not connected to bugzilla, but its probably should resolve one issue I saw
yesterday.
However, please, remove leftover in IrsBrokerCommand before merge.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 557: try {
Line 558: if
(DbFacade.getInstance().isStoragePoolMasterUp(_storagePoolId)) {
Line 559: ResourceManager.getInstance()
Line 560: .getEventListener()
Line 561: .storagePoolUpEvent(storagePool);
You remove the only usage of _isSpmStartCalled.
Please, remove variable itself.
Line 562: }
Line 563: } catch (RuntimeException exp) {
Line 564: log.error("Error in StoragePoolUpEvent - ",
exp);
Line 565: }
--
To view, visit http://gerrit.ovirt.org/19802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2014a2e5c839f2c061b67e6b147c9577914f7101
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
