Alex Lourie has posted comments on this change.
Change subject: packaging: setup: stop and notify if setup is not run as root
......................................................................
Patch Set 1:
(1 comment)
....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 70: 'Error: insufficient permissions for user {user}, '
Line 71: 'you must run with user root.'.format(
Line 72: user=username
Line 73: )
Line 74: )
Considering that this check happens before anything else, I don't think it has
any benefit to log. The message will appear on screen, so the user should have
no problems understanding what the problem is.
Line 75:
Line 76: def dbExists(db_dict):
Line 77: logging.debug("checking if %s db already exists" % db_dict["name"])
Line 78: (output, rc) = utils.execSqlCmd(
--
To view, visit http://gerrit.ovirt.org/18753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
