Michael Kublin has posted comments on this change. Change subject: core: Retrieve job with steps by correlation ID ......................................................................
Patch Set 2: (1 inline comment) Bad performance, read comment .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByCorrelationIdQuery.java Line 21: @Override The performance of the following code is bad. Please improve it. Some idea: Retrieve all jobs by correlattion id. Add a method that JobRepositoryFactory.getJobRepository().getJobWithSteps will accept a job instead of id, fill a job with steps. By such small change a number of queries reduced around 40%. (Additional optimization u can also add a query getJobSubjectEntityByCorrelationId and use a result to fill a jobs retrieved before) -- To view, visit http://gerrit.ovirt.org/2829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97d662bd742a16d01d9767dc4087de5e634fd53a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
